gh-123968: Fix lower bound for python -m random --float#123971
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
`python -m random --float N` incorrectly used a range between 1 and N of length N - 1. Fix it to use a range between 0 and N of length N, as originally specified in python#118131, and as everyone will expect. Fixespython#123968. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Member
hugovk commented Sep 12, 2024
Thanks! |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 12, 2024
…onGH-123971) (cherry picked from commit a362c41) Co-authored-by: Anders Kaseorg <andersk@mit.edu>
GH-124009 is a backport of this pull request to the 3.13 branch. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
python -m random --float Nincorrectly used a range between 1 and N of length N - 1. Fix it to use a range between 0 and N of length N, as originally specified in #118131, and as everyone will expect.python -m random --float Nshould pick a float between 0 and N, not 1 and N #123968