Skip to content

gh-123987: Fix NotADirectoryError in NamespaceReader when sentinel present#124018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jaraco merged 2 commits into from
Jan 26, 2025
Merged

gh-123987: Fix NotADirectoryError in NamespaceReader when sentinel present #124018

jaraco merged 2 commits into from
Jan 26, 2025

Conversation

@jaraco
Copy link
Member

@jaracojaraco commented Sep 12, 2024•
edited
Loading

@jaracojaraco added the needs backport to 3.13 bugs and security fixes label Sep 12, 2024
@bedevere-appbedevere-appbot mentioned this pull request Sep 12, 2024
Closed
@jaracojaraco marked this pull request as draft September 12, 2024 18:33
@jaracojaracoforce-pushed the gh-123987/sentinel-in-namespace-path branch from aaab6d2 to 241d9e9CompareSeptember 12, 2024 18:35
@jaracojaraco changed the title gh-123987: Fix issues in importlib.resources.gh-123987: Fix NotADirectoryError in NamespaceReader when sentinel presentSep 12, 2024
@jaracojaraco mentioned this pull request Sep 12, 2024
Merged
1 task
@jaracojaracoforce-pushed the gh-123987/sentinel-in-namespace-path branch from 241d9e9 to 1c6608aCompareSeptember 12, 2024 19:38
@jaracojaraco marked this pull request as ready for review September 12, 2024 19:40
@jaracojaraco enabled auto-merge (squash) January 5, 2025 21:57
@FFY00
Copy link
Member

FFY00 commented Jan 12, 2025

ping @jaraco

This has been open for a while.

@jaraco
Copy link
MemberAuthor

jaraco commented Jan 26, 2025

ping @jaraco

This has been open for a while.

I've been trying not to merge code without review. I marked this one for auto-merge after review, but no one's reviewed it. Is there a reason you chose to ping me rather than review it? (not complaining, just curious)

I'll get it updated and merged.

@jaracojaraco self-assigned this Jan 26, 2025
@jaracojaraco disabled auto-merge January 26, 2025 16:06
@jaracojaraco enabled auto-merge (squash) January 26, 2025 16:07
@jaracojaraco merged commit b543b32 into python:mainJan 26, 2025
38 checks passed
@miss-islington-app
Copy link

miss-islington-appbot commented Jan 26, 2025

Thanks @jaraco for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 26, 2025
@jaraco@miss-islington
pythongh-123987: Fix NotADirectoryError in NamespaceReader when senti…
2112e26
…nel present (pythonGH-124018) (cherry picked from commit b543b32) Co-authored-by: Jason R. Coombs <[email protected]>
@bedevere-app
Copy link

bedevere-appbot commented Jan 26, 2025

GH-129319 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13 bugs and security fixes label Jan 26, 2025
@jaraco
Copy link
MemberAuthor

jaraco commented Jan 26, 2025

Oh, interesting! This is the first time I've seen the auto-merge work without a second person to review (and manual merge wasn't possible). Great to see some streamlining of workflows.

@jaracojaraco deleted the gh-123987/sentinel-in-namespace-path branch January 26, 2025 17:03
jaraco added a commit that referenced this pull request Jan 26, 2025
@miss-islington@jaraco
[3.13]gh-123987: Fix NotADirectoryError in NamespaceReader when sent…
6e88741
…inel present (GH-124018) (#129319) gh-123987: Fix NotADirectoryError in NamespaceReader when sentinel present (GH-124018) (cherry picked from commit b543b32) Co-authored-by: Jason R. Coombs <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@warsawwarsawAwaiting requested review from warsawwarsaw is a code owner

@FFY00FFY00Awaiting requested review from FFY00FFY00 is a code owner

Assignees

@jaracojaraco

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jaraco@FFY00