gh-123961: add curses prefix to global variable names in _cursesmodule.c#124047
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
picnixz requested review from vstinner and removed request for ericsnowcurrentlypicnixz changed the title curses prefix to global variable names in _cursesmodule.ccurses prefix to global variable names in _cursesmodule.c
vstinner approved these changes Sep 13, 2024
Member
vstinner left a comment
vstinner left a comment There was a problem hiding this comment.
LGTM.
In general, I prefer having a prefix, it avoids name conflicts when I debug in gdb.
| static int curses_start_color_called = FALSE; | ||
| static char *screen_encoding = NULL; | ||
| static const char *curses_screen_encoding = NULL; |
Member
There was a problem hiding this comment.
There is no new compiler warning, so changing type from char* to const char* looks safe.
Uh oh!
There was an error while loading. Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_cursesmodule.cto fix reference leaks #123961