Skip to content

bpo-36346: Prepare for removing the legacy Unicode C API.#12409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
serhiy-storchaka wants to merge 32 commits into from
Closed

bpo-36346: Prepare for removing the legacy Unicode C API. #12409

serhiy-storchaka wants to merge 32 commits into from

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchakaserhiy-storchaka commented Mar 18, 2019•
edited by bedevere-bot
Loading

Add two compile time options: HAVE_UNICODE_WCHAR_CACHE and
USE_UNICODE_WCHAR_CACHE.

USE_UNICODE_WCHAR_CACHE makes the interpreter not using the
wchar_t cache and the legacy Unicode C API.

HAVE_UNICODE_WCHAR_CACHE removes the wchar_t cache and the
legacy Unicode C API that depends on it.

https://bugs.python.org/issue36346

@serhiy-storchaka
bpo-36346: Prepare for removing the legacy Unicode C API.
699e616
Add two compile time options: HAVE_UNICODE_WCHAR_CACHE and USE_UNICODE_WCHAR_CACHE. USE_UNICODE_WCHAR_CACHE makes the interpreter not using the wchar_t cache and the legacy Unicode C API. HAVE_UNICODE_WCHAR_CACHE removes the wchar_t cache and the legacy Unicode C API that depends on it.
scoder
scoder reviewed Mar 18, 2019
View reviewed changes
Copy link
Contributor

@scoderscoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that's a lot of code that will eventually be removed here. Nice!

@methane
Copy link
Member

methane commented Jun 17, 2020

@serhiy-storchaka Would you split this pull request?
clinic should be updated before adding DeprecationWarning in PyArg_Parse*.

@serhiy-storchaka
Copy link
MemberAuthor

serhiy-storchaka commented Jun 29, 2020

@serhiy-storchaka Would you split this pull request?
clinic should be updated before adding DeprecationWarning in PyArg_Parse*.

#21223

methane
methane reviewed Jul 6, 2020
View reviewed changes
@iritkatriel
Copy link
Member

iritkatriel commented Apr 11, 2022

https://bugs.python.org/issue36346 is closed. What is the status of this PR?

@serhiy-storchakaserhiy-storchaka mentioned this pull request May 11, 2022
Merged
@serhiy-storchaka
Copy link
MemberAuthor

serhiy-storchaka commented May 12, 2022

No longer actual after merging #92537.

@serhiy-storchakaserhiy-storchaka deleted the disable-wchar-cache branch May 12, 2022 11:30
@bedevere-botbedevere-bot mentioned this pull request Apr 10, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@methanemethanemethane left review comments

@scoderscoderscoder left review comments

+1 more reviewer

@blesnatalmanblesnatalmanblesnatalman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting core reviewDO-NOT-MERGE

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@serhiy-storchaka@methane@iritkatriel@scoder@blesnatalman@the-knights-who-say-ni@bedevere-bot