Skip to content

Conversation

@zware
Copy link
Member

@zwarezware commented Sep 18, 2024

Set PATH to ensure that `sphinx-autobuild` can find `sphinx-build`.
Copy link
Contributor

@colesburycolesbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This fixes make htmllive for me.

@zwarezware enabled auto-merge (squash) September 18, 2024 20:45
Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zwarezware added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Sep 18, 2024
@zwarezware merged commit 9a6e233 into python:mainSep 18, 2024
@zwarezware deleted the fix_doc_make_htmllive_target branch September 18, 2024 21:02
@miss-islington-app
Copy link

Thanks @zware for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 18, 2024
Allow `make -C Doc htmllive` to work without manual venv activation Set PATH to ensure that `sphinx-autobuild` can find `sphinx-build`. (cherry picked from commit 9a6e233) Co-authored-by: Zachary Ware <[email protected]>
@bedevere-app
Copy link

GH-124221 is a backport of this pull request to the 3.13 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 18, 2024
Allow `make -C Doc htmllive` to work without manual venv activation Set PATH to ensure that `sphinx-autobuild` can find `sphinx-build`. (cherry picked from commit 9a6e233) Co-authored-by: Zachary Ware <[email protected]>
@bedevere-appbedevere-appbot removed the needs backport to 3.13 bugs and security fixes label Sep 18, 2024
@bedevere-app
Copy link

GH-124222 is a backport of this pull request to the 3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12 only security fixes label Sep 18, 2024
savannahostrowski pushed a commit to savannahostrowski/cpython that referenced this pull request Sep 22, 2024
Allow `make -C Doc htmllive` to work without manual venv activation Set PATH to ensure that `sphinx-autobuild` can find `sphinx-build`.
Yhg1s pushed a commit that referenced this pull request Sep 23, 2024
Fix `make htmllive` target (GH-124219) Allow `make -C Doc htmllive` to work without manual venv activation Set PATH to ensure that `sphinx-autobuild` can find `sphinx-build`. (cherry picked from commit 9a6e233) Co-authored-by: Zachary Ware <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docsDocumentation in the Doc dirskip issueskip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@zware@colesbury@hugovk@AA-Turner