bpo-31904: fix test_utf8_mode fail issue on VxWorks#12428
Uh oh!
There was an error while loading. Please reload this page.
Conversation
VxWorks uses UTF-8 as the system encoding.
Lib/test/test_utf8_mode.py Outdated
| MS_WINDOWS = (sys.platform == 'win32') | ||
| POSIX_LOCALES = ('C', 'POSIX') | ||
| _vxworks = (sys.platform == "vxworks") |
There was a problem hiding this comment.
Please rename the constant to VXWORKS.
There was a problem hiding this comment.
I have made the requested changes; please review again
| @@ -0,0 +1,2 @@ | |||
| VxWorks uses UTF-8 as the system encoding. So the test case test_utf8_mode.py | |||
| need to be updated to use UTF-8 on VxWorks. | |||
There was a problem hiding this comment.
I propose:
Fix test_utf8_mode on VxWorks: Python always use UTF-8 on VxWorks .
There was a problem hiding this comment.
I have made the requested changes; please review again
bedevere-bot commented Mar 26, 2019
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Replace _vxworks with VXWORKS for VxWorks
4 participants
VxWorks uses UTF-8 as the system encoding. So the test case test_utf8_mode.py need to be updated to use UTF-8 on VxWorks.
https://bugs.python.org/issue31904