Skip to content

Conversation

@rruuaanng
Copy link
Contributor

@rruuaanngrruuaanng commented Sep 22, 2024

I'm looking for a better solution for this, if anyone finds one I can close this PR.

@bedevere-app
Copy link

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@rruuaanngrruuaanng changed the title gh-124309: Fix the exception when using the happy_eyeballs_delay parameter in open_connectiongh-124309: Fix the exception when using the happy_eyeballs_delay argument in open_connectionSep 22, 2024
@rruuaanngrruuaanng changed the title gh-124309: Fix the exception when using the happy_eyeballs_delay argument in open_connectiongh-124309: Fix the AssertionError when using the happy_eyeballs_delay argument in open_connectionSep 22, 2024
@Wulian233
Copy link
Contributor

This change seems incorrect

1 test failed:
test.test_asyncio.test_staggered

@rruuaanng
Copy link
ContributorAuthor

rruuaanng commented Sep 22, 2024

This change seems incorrect

1 test failed: test.test_asyncio.test_staggered

I know, I'll take up this PR and look for a solution.

@rruuaanngrruuaanng reopened this Sep 22, 2024
@bedevere-app
Copy link

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app
Copy link

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@rruuaanng
Copy link
ContributorAuthor

rruuaanng commented Sep 22, 2024

Hmm, ok I give up, it seems this can only be tested on my computer.

PS E:\code\cc\cpython\alpha\cpython-main\Lib\test\test_asyncio> ../../../python.bat -m unittest discover Running Release|x64 interpreter... .....................................................................s........s............s.................................................................................ss.....................s.......sssssss.s.sssss......ss........s.......ssssss.ss.....................s.......sssssss...ss........ss..ssss..................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................sss.s....ss...............s.s..s................s..s..........s....sssss........s.....s........s...s.....................................................................................sss...............................s............................s.......s........s.............................................................................................................................................................................................................................................................................................................................................................s............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................s.................................... ---------------------------------------------------------------------- Ran 2224 tests in 111.233s OK (skipped=76) 

I apologize for opening the PR again.

@rruuaanngrruuaanng deleted the gh124309 branch November 6, 2024 11:16
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@rruuaanng@Wulian233