gh-119333: PyContext watchers notify get interp from tstate#124444
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ContributorAuthor
fried commented Sep 24, 2024
@kumaraditya303 Is this better? |
ContributorAuthor
fried commented Sep 24, 2024
Need a "skip news" label since the last pull had the news this is just a fix |
Uh oh!
There was an error while loading. Please reload this page.
kumaraditya303 approved these changes Sep 26, 2024
gvanrossum approved these changes Sep 26, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a suggestion from #119335 that we should be getting the *interp from tstate instead.
Also attempting to clean up comments as suggested.