Skip to content

Conversation

@tomasr8
Copy link
Member

@tomasr8tomasr8 commented Sep 25, 2024

I think I more or less understood how this is supposed to work, but please let me know if I missed something :)
Also, if you think I should add more tests.

@tomasr8
Copy link
MemberAuthor

Just trying to debug this weird error now:

Objects/tupleobject.c:408: _PyObject_GC_TRACK: Assertion "!_PyObject_GC_IS_TRACKED(((PyObject*)(op)))" failed: object already tracked by the garbage collector Fatal Python error: Segmentation fault 

Unfortunately seems to only happen when running the tests, not when I run the test case as a script :/

tomasr8and others added 2 commits September 25, 2024 22:05
@tomasr8
Copy link
MemberAuthor

Ready for another round :)

@tomasr8tomasr8 requested a review from DaraanNovember 16, 2024 21:59
@tomasr8
Copy link
MemberAuthor

ping @JelleZijlstra in case you forgot about this 🙂

Copy link
Member

@JelleZijlstraJelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I'm going to run refleak tests locally to make sure I'm not missing something.

@JelleZijlstraJelleZijlstra merged commit bbf1979 into python:mainMar 3, 2025
46 checks passed
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86 Debian Installed with X 3.x (no tier) has failed when building commit bbf1979.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1244/builds/4460) and take a look at the build logs.
  4. Check if the failure is related to this commit (bbf1979) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1244/builds/4460

Failed tests:

  • test.test_concurrent_futures.test_process_pool

Failed subtests:

  • test_force_shutdown_workers - test.test_concurrent_futures.test_process_pool.ProcessPoolForkserverProcessPoolExecutorTest.test_force_shutdown_workers

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last): File "/buildbot/buildarea/3.x.ware-debian-x86.installed/build/target/lib/python3.14/test/test_importlib/metadata/fixtures.py", line 391, in _inner func(self, **args) ~~~~^^^^^^^^^^^^^^ File "/buildbot/buildarea/3.x.ware-debian-x86.installed/build/target/lib/python3.14/test/test_concurrent_futures/test_process_pool.py", line 281, in test_force_shutdown_workersself.assertEqual(worker_process.exitcode, -signal.SIGKILL) ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError: 255 != -9

@tomasr8tomasr8 deleted the paramspec-alias branch March 4, 2025 08:37
@tomasr8
Copy link
MemberAuthor

Buildbot failure seems unrelated

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@tomasr8@bedevere-bot@JelleZijlstra@Daraan@AlexWaygood