Skip to content

Conversation

@rhansen
Copy link
Contributor

@rhansenrhansen commented Sep 28, 2024

The PyContext struct is not intended to be public, and users of the API don't need anything more specific than PyObject. Also see gh-78943.

I don't think a NEWS blurb is needed because this amends a feature that is new to v3.14 so the existing blurb should suffice.

cc @fried


📚 Documentation preview 📚: https://cpython-previews--124737.org.readthedocs.build/

@bedevere-app
Copy link

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app
Copy link

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app
Copy link

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@rhansenrhansen changed the title gh-119333: Change PyContext_WatchCallback to take PyObjectgh-124872: Change PyContext_WatchCallback to take PyObjectOct 1, 2024
@rhansenrhansenforce-pushed the gh-119333-context-watch branch from ac65639 to 7681358CompareOctober 10, 2024 08:45
@1st1
Copy link
Member

1st1 commented Oct 12, 2024

@rhansen please rebase

The PyContext struct is not intended to be public, and users of the API don't need anything more specific than PyObject. Also see pythongh-78943.
@rhansenrhansenforce-pushed the gh-119333-context-watch branch from 7681358 to 79df721CompareOctober 12, 2024 20:28
Copy link
Member

@1st11st1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good refactoring and jives well with the idea that C API should expose (PyObject*) for objects and not their concrete structs.

@1st11st1 merged commit 330c527 into python:mainOct 12, 2024
@rhansenrhansen deleted the gh-119333-context-watch branch October 12, 2024 21:02
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@rhansen@1st1