Skip to content

Conversation

@picnixz
Copy link
Member

@picnixzpicnixz commented Sep 29, 2024

Using Py_DECREF on an object that could be NULL (my bad).

@picnixzpicnixz changed the title gh-123961: fix a decref usage in _cursesmodule.cgh-123290: fix a decref usage in _cursesmodule.cSep 29, 2024
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinnervstinner enabled auto-merge (squash) September 29, 2024 14:33
@vstinnervstinner enabled auto-merge (squash) September 29, 2024 14:34
@vstinnervstinner merged commit 12417a9 into python:mainSep 29, 2024
@picnixzpicnixz deleted the curses/fix-decref-on-null-123961 branch September 29, 2024 15:04
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 Android 3.x has failed when building commit 12417a9.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1594/builds/141) and take a look at the build logs.
  4. Check if the failure is related to this commit (12417a9) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1594/builds/141

Failed tests:

  • test_os

Failed subtests:

  • test_timerfd_ns_poll - test.test_os.TimerfdTests.test_timerfd_ns_poll

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last): File "/data/user/0/org.python.testbed/files/python/lib/python3.14/test/test_os.py", line 4394, in test_timerfd_ns_pollself.check_timerfd_poll(True) ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^ File "/data/user/0/org.python.testbed/files/python/lib/python3.14/test/test_os.py", line 4379, in check_timerfd_pollself.assertEqual(self.read_count_signaled(fd), 1) ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError: 2 != 1

@mhsmith
Copy link
Member

Buildbot failure is unrelated:

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@picnixz@bedevere-bot@mhsmith@vstinner