gh-124309: Revert eager task factory fix to prevent breaking downstream#124810
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…n to support eager task factories (python#124390)" This reverts commit de929f3.
ZeroIntensity requested review from 1st1, asvetlov, gvanrossum, kumaraditya303 and willingc as code owners
MemberAuthor
ZeroIntensity commented Sep 30, 2024
This is a blocker for 3.12.7 |
gvanrossum approved these changes Sep 30, 2024
Member
gvanrossum left a comment
gvanrossum left a comment There was a problem hiding this comment.
I agree. Hopefully it's not too late. @Yhg1s.
Thanks @ZeroIntensity for the PR, and @Yhg1s for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 1, 2024
…wnstream (pythonGH-124810) * Revert "pythonGH-124639: add back loop param to staggered_race (pythonGH-124700)" This reverts commit e0a41a5. * Revert "pythongh-124309: Modernize the `staggered_race` implementation to support eager task factories (pythonGH-124390)" This reverts commit de929f3. (cherry picked from commit 133e929) Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
GH-124817 is a backport of this pull request to the 3.12 branch. |
MemberAuthor
ZeroIntensity commented Oct 1, 2024
Thank you, Thomas! |
Yhg1s pushed a commit that referenced this pull request Oct 1, 2024
…ownstream (GH-124810) (#124817) gh-124309: Revert eager task factory fix to prevent breaking downstream (GH-124810) * Revert "GH-124639: add back loop param to staggered_race (GH-124700)" This reverts commit e0a41a5. * Revert "gh-124309: Modernize the `staggered_race` implementation to support eager task factories (GH-124390)" This reverts commit de929f3. (cherry picked from commit 133e929) Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @Yhg1s
The new implementation using
TaskGrouphas been causing a number of problems, and I'm not comfortable with it going into 3.12.7. Namely, 3.12.7 will break aiohttp and aiohappyeyeballs downstream. See this issue and some of the discussion from this issue.