bpo-36345: Add a new example in the documentation of wsgiref#12511
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
eamanu approved these changes Mar 25, 2019
Contributor
eamanu left a comment
eamanu left a comment There was a problem hiding this comment.
lgtm. IMO should be good tell how the example is executed.
brettcannon approved these changes Mar 25, 2019
Uh oh!
There was an error while loading. Please reload this page.
Member
brettcannon commented Mar 25, 2019
One minor change and then we can merge this! (I tried to merge it myself but you didn't give repo owners edit rights on your PRs, @matrixise ). |
Co-Authored-By: matrixise <stephane@wirtel.be>
MemberAuthor
matrixise commented Mar 25, 2019
Thank you so much @brettcannon , About the rights, this is strange because I just create this PR and I think the flag was checked. really sorry. |
bedevere-bot commented Mar 25, 2019
@brettcannon: Please replace |
Member
brettcannon commented Mar 25, 2019
Thanks! |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's the second PR where I convert the code of
Tools/scripts/serve.pyas an example in the documentation ofwsgiref.https://bugs.python.org/issue36345