bpo-36427: Document that PyEval_RestoreThread and PyGILState_Ensure can terminate the calling thread#12541
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…an terminate the calling thread
eamanu approved these changes Mar 26, 2019
vstinner approved these changes Mar 26, 2019
Member
vstinner left a comment
vstinner left a comment There was a problem hiding this comment.
LGTM, but I have a question :-)
Uh oh!
There was an error while loading. Please reload this page.
pitrou reviewed Mar 26, 2019
Uh oh!
There was an error while loading. Please reload this page.
Contributor
miss-islington commented Apr 13, 2019
Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
pablogsal added a commit to pablogsal/cpython that referenced this pull request Apr 13, 2019
…sure can terminate the calling thread (pythonGH-12541) Calling these function from a thread when the runtime is finalizing will terminate the thread, even if the thread was not created by Python. Users can use _Py_IsFinalizing or sys.is_finalizing to check if the interpreter is in the process of being finalized before calling this function to avoid unwanted termination. (cherry picked from commit fde9b33) Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
bedevere-bot commented Apr 13, 2019
GH-12820 is a backport of this pull request to the 3.7 branch. |
pablogsal added a commit that referenced this pull request Apr 14, 2019
…sure can terminate the calling thread (GH-12541) (GH-12820) Calling these function from a thread when the runtime is finalizing will terminate the thread, even if the thread was not created by Python. Users can use _Py_IsFinalizing or sys.is_finalizing to check if the interpreter is in the process of being finalized before calling this function to avoid unwanted termination. (cherry picked from commit fde9b33)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue36427