Skip to content

gh-125196: Use PyUnicodeWriter in HAMT#125458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 3 commits into from
Oct 15, 2024
Merged

gh-125196: Use PyUnicodeWriter in HAMT #125458

vstinner merged 3 commits into from
Oct 15, 2024

Conversation

@vstinner
Copy link
Member

@vstinnervstinner commented Oct 14, 2024•
edited by bedevere-app bot
Loading

Replace the private _PyUnicodeWriter API with the public PyUnicodeWriter API in hamt.c.

Remove _hamt_dump_format(): replace it with PyUnicodeWriter_Format().

Use PyUnicodeWriter_WriteUTF8() to write constant strings.

@vstinner
pythongh-125196: Use PyUnicodeWriter in HAMT
974e343
Replace the private _PyUnicodeWriter API with the public PyUnicodeWriter API in hamt.c. Remove _hamt_dump_format(): replace it with PyUnicodeWriter_Format(). Use PyUnicodeWriter_WriteUTF8() to write constant strings.
@vstinnervstinner requested a review from 1st1 as a code ownerOctober 14, 2024 14:52
@bedevere-appbedevere-appbot mentioned this pull request Oct 14, 2024
Closed
picnixz
picnixz reviewed Oct 14, 2024
View reviewed changes
@vstinner@picnixz
Apply suggestions from code review
3cc9e8c
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@vstinnervstinner enabled auto-merge (squash) October 14, 2024 18:35
@nineteendo
Copy link
Contributor

nineteendo commented Oct 14, 2024

You need to update the branch first.

@vstinner
Copy link
MemberAuthor

vstinner commented Oct 15, 2024

You need to update the branch first.

Right, done.

@vstinnervstinner merged commit aa18fd5 into python:mainOct 15, 2024
@vstinnervstinner deleted the writer_hamt branch October 15, 2024 09:47
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixzpicnixzpicnixz left review comments

@1st11st11st1 approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vstinner@nineteendo@1st1@picnixz