Skip to content

Conversation

@graingert
Copy link
Contributor

@graingertgraingert commented Oct 14, 2024

@graingertgraingert changed the title gh-124958: fix asyncio.TaskGroup and _PyFuture refcycles (#124959)[3.12] gh-124958: fix asyncio.TaskGroup and _PyFuture refcycles (#124959)Oct 14, 2024
@graingertgraingert reopened this Oct 14, 2024
@graingertgraingert marked this pull request as ready for review October 14, 2024 15:45
@1st1
Copy link
Member

1st1 commented Oct 15, 2024

What's this DO NOT MERGE label business?

@graingert
Copy link
ContributorAuthor

What's this DO NOT MERGE label business?

@1st1 this was related to a failure on 3.14 (main) caused by a conflict with a different PR #124392

The do not merge label was added out of an abundance of caution assuming this PR was flaky when it is not. I removed the label

@1st11st1 merged commit 32d4579 into python:3.12Oct 17, 2024
@graingertgraingert deleted the backport-d5dbbf4-3.12 branch October 17, 2024 07:44
@gvanrossum
Copy link
Member

What's this DO NOT MERGE label business?

@1st1 this was related to a failure on 3.14 (main) caused by a conflict with a different PR #124392

The do not merge label was added out of an abundance of caution assuming this PR was flaky when it is not. I removed the label

Sure, but please understand not everyone is aware of the reasons, so next time please add a comment to explain. (Also my pet peeve for revert PRs, too few people don’t say why it is being reverted and the OP has to hunt for the reason.)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@graingert@1st1@gvanrossum@kumaraditya303