Skip to content

gh-125543: Add an internal C API for dynamic arrays#125554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ZeroIntensity wants to merge 22 commits into from
Closed

gh-125543: Add an internal C API for dynamic arrays #125554

ZeroIntensity wants to merge 22 commits into from

Conversation

@ZeroIntensity
Copy link
Member

@ZeroIntensityZeroIntensity commented Oct 15, 2024•
edited by bedevere-app bot
Loading

@bedevere-appbedevere-appbot mentioned this pull request Oct 15, 2024
Closed
Eclips4
Eclips4 reviewed Oct 15, 2024
View reviewed changes
@ZeroIntensityZeroIntensity marked this pull request as ready for review October 19, 2024 16:33
Eclips4
Eclips4 reviewed Oct 19, 2024
View reviewed changes
Eclips4
Eclips4 approved these changes Oct 19, 2024
View reviewed changes
Copy link
Member

@Eclips4Eclips4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current implementation and API look good to me. Let's see what others think.

@Eclips4Eclips4 requested a review from vstinnerOctober 19, 2024 21:17
vstinner
vstinner requested changes Oct 19, 2024
View reviewed changes
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point, I'm not convinced that there is a need for such API. I suggest to discuss it on the issue.

@bedevere-app
Copy link

bedevere-appbot commented Oct 19, 2024

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner requested changes

@Eclips4Eclips4Eclips4 approved these changes

@erlend-aaslanderlend-aaslandAwaiting requested review from erlend-aaslanderlend-aasland is a code owner

Assignees

No one assigned

Labels

awaiting changesskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ZeroIntensity@vstinner@Eclips4