gh-125017: Fix crash on premature access to classmethod/staticmethod annotations#125636
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
ZeroIntensity commented Oct 17, 2024
Is there any backport needed here? I'm not sure if the original PR made it in 3.13 |
MemberAuthor
JelleZijlstra commented Oct 17, 2024
No, this is a PEP 649 change and is only on main. |
Member
zware commented Oct 17, 2024
Heads-up: this appears to have caused some refleak buildbot failures, see for example https://buildbot.python.org/#/builders/1613/builds/116 |
zware added a commit to zware/cpython that referenced this pull request Oct 17, 2024
zware added a commit that referenced this pull request Oct 17, 2024
Member
ZeroIntensity commented Oct 17, 2024
Actually, on a second look, this part is technically unsafe: else{Py_DECREF(dict); returnPyDict_SetItem(dict, name, value)}If the dictionary's reference count is 1, then this will result in a use-after-free. Though, I guess that's never possible because the dictionary will be stored on the instance as well. In hindsight, there should have either been an assertion (or just not do it in the first place), but oh well. |
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cls.__dict__['__new__'].__annotations__#125017