Skip to content

Conversation

@terryjreedy
Copy link
Member

@terryjreedyterryjreedy commented Oct 17, 2024

Rewriting the day and date every tick somehow prevented them from being removed either by clicking STOP or loading another example. The solution is to rewrite them only when they change. (cherry picked from commit c124577)

…tledemo.clock (pythonGH-123457) Rewriting the day and date every tick somehow prevented them from being removed either by clicking STOP or loading another example. The solution is to rewrite them only when they change. (cherry picked from commit c124577) Co-authored-by: Wulian <[email protected]>
@terryjreedyterryjreedy added the needs backport to 3.12 only security fixes label Oct 17, 2024
@terryjreedyterryjreedy self-assigned this Oct 17, 2024
@terryjreedyterryjreedy changed the title [3.13] gh-123370: Fix the canvas not clearing after running turtledem…[3.13] gh-123370: Fix the canvas not clearing after running turtledemo.clockOct 17, 2024
@terryjreedyterryjreedy changed the title [3.13] gh-123370: Fix the canvas not clearing after running turtledemo.clock[3.13] gh-123370: Fix the canvas not clearing after running turtledemo.clock (gh-123457)Oct 17, 2024
@terryjreedyterryjreedy merged commit 30d7e9e into python:3.13Oct 17, 2024
@miss-islington-app
Copy link

Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 17, 2024
…tledemo.clock (pythongh-123457) (pythonGH-125653) [3.13] pythongh-123370: Fix the canvas not clearing after running turtledemo.clock (pythonGH-123457) Rewriting the day and date every tick somehow prevented them from being removed either by clicking STOP or loading another example. The solution is to rewrite them only when they change. (cherry picked from commit c124577) (cherry picked from commit 30d7e9e) Co-authored-by: Terry Jan Reedy <[email protected]> Co-authored-by: Wulian <[email protected]>
@bedevere-app
Copy link

GH-125656 is a backport of this pull request to the 3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12 only security fixes label Oct 17, 2024
@terryjreedyterryjreedy deleted the backport-c124577-3.13 branch October 17, 2024 16:51
terryjreedy added a commit that referenced this pull request Oct 17, 2024
…rtledemo.clock (gh-123457) (GH-125653) (#125656) Rewriting the day and date every tick somehow prevented them from being removed either by clicking STOP or loading another example. The solution is to rewrite them only when they change. (cherry picked from commit c124577) (cherry picked from commit 30d7e9e) Co-authored-by: Terry Jan Reedy <[email protected]> Co-authored-by: Wulian <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@terryjreedy@Wulian233