gh-125698: Replace EXEEXT with EXE_SUFFIX#125699
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ContributorAuthor
erlend-aasland commented Oct 18, 2024
We might need a NEWS entry for this for the build section. I'm not sure yet. |
ned-deily approved these changes Oct 18, 2024
Member
ned-deily left a comment
ned-deily left a comment There was a problem hiding this comment.
From a visual inspection (without any build testing), the changes look OK and harmless to me. It appears that the current EXEEXT is used only for creating the configured Makefile and doesn't appear as a variable directly in the finished product. So that doesn't seem like it counts as an external interface requiring documentation.
ContributorAuthor
erlend-aasland commented Oct 18, 2024
Thank for the review, Ned. Yeah, that was my conclusion as well. |
ContributorAuthor
erlend-aasland commented Oct 18, 2024
I'll land this in a couple of days, in case anyone has objections. |
ContributorAuthor
erlend-aasland commented Oct 20, 2024
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EXEEXThacks are interfering withAX_C_FLOAT_WORDS_BIGENDIAN#125698