Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34k
gh-125741: Update check_generated_files CI to use our published container image#125744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
corona10 commented Oct 20, 2024
I verified the the workflows well through https://github.com/python/cpython/actions/runs/11422707050/job/31781018424 Let's handle it separately. |
Damien-Chen commented Oct 20, 2024
Since the container python used has something different from Github Action official base image and that is the reason why we should switch to the internal container ? |
corona10 commented Oct 20, 2024 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
See: https://discuss.python.org/t/pinning-gnu-autotools-using-the-github-container-registry/47437/29 FYI, The purpose of CI is verification of whether the person generate autoconf properly So that’s why we have to unify the image to be same. |
erlend-aasland commented Oct 20, 2024
Thanks. I need this for #125571. |
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Damien-Chen commented Oct 20, 2024
Does that should be backport to 3.13 and 3.12 ? |
erlend-aasland commented Oct 20, 2024
I think we should backport it, yes. Hugo? |
hugovk commented Oct 20, 2024
Yes, it'll be easier to maintain if the three branches are more similar. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
GH-125759 is a backport of this pull request to the 3.13 branch. |
…blished container image (pythongh-125744) (cherry picked from commit ed24702) Co-authored-by: Donghee Na <donghee.na@python.org>
This comment was marked as resolved.
This comment was marked as resolved.
GH-125760 is a backport of this pull request to the 3.12 branch. |
…blished container image (pythongh-125744) (cherry picked from commit ed24702) Co-authored-by: Donghee Na <donghee.na@python.org>
Uh oh!
There was an error while loading. Please reload this page.