gh-123930: Correct test of attribute failure to account for iOS#125959
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
freakboy3742 added skip issue skip news 3.13 freakboy3742 requested review from brettcannon, ericsnowcurrently, ncoghlan and warsaw as code owners
ContributorAuthor
freakboy3742 commented Oct 25, 2024
!buildbot iOS |
bedevere-bot commented Oct 25, 2024
🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 41ed908 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
hauntsaninja approved these changes Oct 25, 2024
Contributor
hauntsaninja left a comment
hauntsaninja left a comment There was a problem hiding this comment.
Thank you for the quick fix!
ContributorAuthor
freakboy3742 commented Oct 25, 2024
!buildbot iOS |
bedevere-bot commented Oct 25, 2024
🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 8111d82 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
Thanks @freakboy3742 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 25, 2024
…pythonGH-125959) Update a test of importing attributes from binary modules to account for iOS conditions. (cherry picked from commit 75401fe) Co-authored-by: Russell Keith-Magee <[email protected]>
GH-125960 is a backport of this pull request to the 3.13 branch. |
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Dec 13, 2024
…for iOS (pythonGH-125959) (python#125960) pythongh-123930: Correct test of attribute failure to account for iOS (pythonGH-125959) Update a test of importing attributes from binary modules to account for iOS conditions. (cherry picked from commit 75401fe) Co-authored-by: Russell Keith-Magee <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Dec 13, 2024
…for iOS (pythonGH-125959) (python#125960) pythongh-123930: Correct test of attribute failure to account for iOS (pythonGH-125959) Update a test of importing attributes from binary modules to account for iOS conditions. (cherry picked from commit 75401fe) Co-authored-by: Russell Keith-Magee <[email protected]>
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
…python#125959) Update a test of importing attributes from binary modules to account for iOS conditions.
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Feb 3, 2026
…for iOS (pythonGH-125959) (python#125960) pythongh-123930: Correct test of attribute failure to account for iOS (pythonGH-125959) Update a test of importing attributes from binary modules to account for iOS conditions. (cherry picked from commit 75401fe) Co-authored-by: Russell Keith-Magee <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Feb 3, 2026
…for iOS (pythonGH-125959) (python#125960) pythongh-123930: Correct test of attribute failure to account for iOS (pythonGH-125959) Update a test of importing attributes from binary modules to account for iOS conditions. (cherry picked from commit 75401fe) Co-authored-by: Russell Keith-Magee <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#123929 improved the error message when a Python module shadows a binary module.
However, the test that was added didn't account for the behavior of the iOS import scheme. On iOS, the spec origin and the module's
__file__aren't equivalent, due to the iOS Framework loader. As a result, the test which was looking for the module's__file__in the exception that is raised failed on the iOS buildbots.On every other platform, The spec.origin and the module's
__file__are the same, so this PR updates the test to use the spec's origin.