Skip to content

gh-101123: Adapt vararg functions in the math module to Argument Clinic#126235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
erlend-aasland merged 2 commits into from
Oct 31, 2024
Merged

gh-101123: Adapt vararg functions in the math module to Argument Clinic #126235

erlend-aasland merged 2 commits into from
Oct 31, 2024

Conversation

@skirpichev
Copy link
Member

@skirpichevskirpichev commented Oct 31, 2024•
edited by bedevere-app bot
Loading

@bedevere-appbedevere-appbot mentioned this pull request Oct 31, 2024
Closed
@skirpichevskirpichev mentioned this pull request Oct 31, 2024
Merged
sobolevn
sobolevn approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@sobolevnsobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I support using more AC in the stdlib.

@erlend-aaslanderlend-aasland changed the title gh-101123: convert vararg functions in the math module to ACgh-101123: Adapt vararg functions in the math module to Argument ClinicOct 31, 2024
erlend-aasland
erlend-aasland approved these changes Oct 31, 2024
View reviewed changes
@erlend-aasland
Copy link
Contributor

erlend-aasland commented Oct 31, 2024

I support using more AC in the stdlib.

+1, and so does the faster CPython team.

@erlend-aaslanderlend-aasland linked an issue Oct 31, 2024 that may be closed by this pull request
invalid signature for math.hypot #101123
Closed
@erlend-aaslanderlend-aasland enabled auto-merge (squash) October 31, 2024 14:23
@erlend-aaslanderlend-aasland merged commit 3275cb1 into python:mainOct 31, 2024
@skirpichevskirpichev deleted the vararg-ac branch October 31, 2024 14:39
@erlend-aasland
Copy link
Contributor

erlend-aasland commented Oct 31, 2024

Thanks, Sergey!

@erlend-aaslanderlend-aasland mentioned this pull request Nov 6, 2024
Closed
@serhiy-storchakaserhiy-storchaka mentioned this pull request Nov 6, 2024
Merged
picnixz pushed a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
@skirpichev@picnixz
pythongh-101123: Adapt vararg functions in the math module to Argumen…
dfba2c2
…t Clinic (python#126235) This implicitly fixes the math.hypot signature, which was previously incomprehensible to inspect.signature().
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@skirpichev@ebonnal
pythongh-101123: Adapt vararg functions in the math module to Argumen…
df79d35
…t Clinic (python#126235) This implicitly fixes the math.hypot signature, which was previously incomprehensible to inspect.signature().
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes

@sobolevnsobolevnsobolevn approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

invalid signature for math.hypot

3 participants

@skirpichev@erlend-aasland@sobolevn