gh-99108: Cleanup references to inexisting Modules/_blake2.#126270
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
picnixz requested review from a team, corona10, ericsnowcurrently and erlend-aasland as code owners
The folder does not exist anymore.
gpshead approved these changes Nov 1, 2024
gpshead added needs backport to 3.13 picnixz deleted the chore/remove-blake2-internal-module-references-99108 branch MemberAuthor
picnixz commented Nov 1, 2024
Thank you for the quick review! |
picnixz added a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
…ythonGH-126270) * Remove references to `Modules/_blake2`. * Remove `Modules/_blake2` entry from CODEOWNERS The folder does not exist anymore. * Remove `Modules/_blake2` entry from `Tools/c-analyzer/TODO`
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
…ythonGH-126270) * Remove references to `Modules/_blake2`. * Remove `Modules/_blake2` entry from CODEOWNERS The folder does not exist anymore. * Remove `Modules/_blake2` entry from `Tools/c-analyzer/TODO`
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #119316, we removed the internal
Modules/_blake2folder but there were some occurrences left. Somtimes I see this (empty) folder appear in my branch, probably generated byconfigureor something else. This PR removes the bits related to this (now) inexisting folder.cc @msprotz@gpshead