Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34k
gh-126366: Make native generators thread safe#126371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
Conversation
ZeroIntensity commented Nov 3, 2024 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
corona10 commented Nov 3, 2024
cc @colesbury |
corona10 commented Nov 3, 2024
I will try to take a look at today :) |
Uh oh!
There was an error while loading. Please reload this page.
list.__init__ZeroIntensity commented Nov 4, 2024
Closing in favor of #120327 |
Fidget-Spinner commented Nov 6, 2024
Wait I closed my PR in favour of yours... 😆 @ZeroIntensity |
ZeroIntensity commented Nov 6, 2024
Ah! I'll reopen this and list you as a co-author if yours has merge conflicts. |
Uh oh!
There was an error while loading. Please reload this page.
vstinner left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a warning:
Check warning on line 129 in Python/ceval_macros.h
‘gen_frame’ may be used uninitialized in this function [-Wmaybe-uninitialized]
vstinner left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The overall approach LGTM. I'm feeling more confortable with more critical sections :-)
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Victor Stinner <vstinner@python.org>
This reverts commit 770ce09.
colesbury commented Jan 2, 2025
|
Co-authored-by: Ken Jin kenjin@python.org
ChainMapof aCounterin threads #126366