gh-126451: Register contextvars.Context to collections.abc.Mapping#126452
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ContributorAuthor
tungol commented Nov 5, 2024
The test failure doesn't reproduce locally for me, and I'm not sure how my MR is related. I'm open to suggestions. |
sobolevn reviewed Nov 5, 2024
Uh oh!
There was an error while loading. Please reload this page.
sobolevn reviewed Nov 5, 2024
Misc/NEWS.d/next/Library/2024-11-05-11-28-45.gh-issue-126451.XJMtqz.rst Outdated Show resolvedHide resolved
Uh oh!
There was an error while loading. Please reload this page.
…JMtqz.rst Co-authored-by: sobolevn <[email protected]>
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Alex Waygood <[email protected]>
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Alex Waygood <[email protected]>
AlexWaygood approved these changes Nov 5, 2024
sobolevn approved these changes Nov 6, 2024
Uh oh!
There was an error while loading. Please reload this page.
AlexWaygood added needs backport to 3.12 
ZeroIntensity approved these changes Nov 6, 2024
Member
ZeroIntensity left a comment
ZeroIntensity left a comment There was a problem hiding this comment.
LGTM, with one extra nitpick about adding an issubclass check to the test.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Peter Bierma <[email protected]>
Co-authored-by: Peter Bierma <[email protected]>
Member
sobolevn commented Nov 6, 2024
Thanks everyone! |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 6, 2024
…ing (pythonGH-126452) (cherry picked from commit 5dc36dc) Co-authored-by: Stephen Morton <[email protected]> Co-authored-by: sobolevn <[email protected]> Co-authored-by: Alex Waygood <[email protected]> Co-authored-by: Peter Bierma <[email protected]>
sobolevn removed needs backport to 3.12 
GH-126518 is a backport of this pull request to the 3.13 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 6, 2024
…ing (pythonGH-126452) (cherry picked from commit 5dc36dc) Co-authored-by: Stephen Morton <[email protected]> Co-authored-by: sobolevn <[email protected]> Co-authored-by: Alex Waygood <[email protected]> Co-authored-by: Peter Bierma <[email protected]>
GH-126519 is a backport of this pull request to the 3.12 branch. |
Member
Should we really backport this? |
Member
AlexWaygood commented Nov 6, 2024
We backported #126419 (see discussion in that PR). But I agree it's borderline; I don't feel strongly! Feel free to close the backports if you'd rather not. |
Member
sobolevn commented Nov 6, 2024
Let's be consistent with #126419 👍 |
sobolevn added a commit that referenced this pull request Nov 6, 2024
…ping (GH-126452) (#126519) gh-126451: Register contextvars.Context to collections.abc.Mapping (GH-126452) (cherry picked from commit 5dc36dc) Co-authored-by: Stephen Morton <[email protected]> Co-authored-by: sobolevn <[email protected]> Co-authored-by: Alex Waygood <[email protected]> Co-authored-by: Peter Bierma <[email protected]>
sobolevn added a commit that referenced this pull request Nov 6, 2024
…ping (GH-126452) (#126518) gh-126451: Register contextvars.Context to collections.abc.Mapping (GH-126452) (cherry picked from commit 5dc36dc) Co-authored-by: Stephen Morton <[email protected]> Co-authored-by: sobolevn <[email protected]> Co-authored-by: Alex Waygood <[email protected]> Co-authored-by: Peter Bierma <[email protected]>
AlexWaygood added a commit to AlexWaygood/cpython that referenced this pull request Nov 12, 2024
…ctions.abc.Mapping (pythonGH-126452) (python#126518)" This reverts commit 59316a6.
AlexWaygood added a commit to AlexWaygood/cpython that referenced this pull request Nov 12, 2024
…ctions.abc.Mapping (pythonGH-126452) (python#126519)" This reverts commit d71da0f.
picnixz pushed a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
…ing (python#126452) Co-authored-by: sobolevn <[email protected]> Co-authored-by: Alex Waygood <[email protected]> Co-authored-by: Peter Bierma <[email protected]>
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
…ing (python#126452) Co-authored-by: sobolevn <[email protected]> Co-authored-by: Alex Waygood <[email protected]> Co-authored-by: Peter Bierma <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR registers
contextvars.Contexttocollections.abc.Mapping. It's already documented thatContextimplements theMappinginterface.