Skip to content

bpo-31904 : skip test_cmd_line case for VxWorks doesn't support preexec#12648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 6 commits into from
Apr 17, 2019
Merged

bpo-31904 : skip test_cmd_line case for VxWorks doesn't support preexec #12648

vstinner merged 6 commits into from
Apr 17, 2019

Conversation

@LihuaZhao
Copy link
Contributor

@LihuaZhaoLihuaZhao commented Apr 1, 2019•
edited by bedevere-bot
Loading

subprocess.Popen doesn't support preexec on VxWorks, test_cmd_line need to skip the case which use preexec

https://bugs.python.org/issue31904

@LihuaZhao
bpo-31904: skip some test case in test_cmd_line for VxWorks doesn't
e64be8c
support preexec subprocess.Popen doesn't support preexec, test_cmd_line need to skip the case which use preexec
@LihuaZhao
add news file
3762b12
@bedevere-botbedevere-bot added tests Tests in the Lib/test dir awaiting review labels Apr 1, 2019
@LihuaZhaoLihuaZhao reopened this Apr 4, 2019
vstinner
vstinner requested changes Apr 17, 2019
View reviewed changes
Lib/test/test_cmd_line.py Outdated
if sys.platform == "vxworks":
return False
else:
return True
Copy link
Member

@vstinnervstinnerApr 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest:

SUBPROCESS_SUPPORTS_PREEXEC = (sys.platform != "vxworks")

@bedevere-bot
Copy link

bedevere-bot commented Apr 17, 2019

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

vstinner
vstinner requested changes Apr 17, 2019
View reviewed changes
@LihuaZhao
Copy link
ContributorAuthor

LihuaZhao commented Apr 17, 2019

I have made the requested changes; please review again.

@bedevere-bot
Copy link

bedevere-bot commented Apr 17, 2019

Thanks for making the requested changes!

@vstinner: please review the changes made to this pull request.

vstinner
vstinner requested changes Apr 17, 2019
View reviewed changes
Lib/test/test_cmd_line.py
# Debug build?
Py_DEBUG = hasattr(sys, "gettotalrefcount")


Copy link
Member

@vstinnervstinnerApr 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum, please revert this unrelated change.

Misc/NEWS.d/next/Tests/2019-04-01-17-44-36.bpo-31904.32Ef3G.rst Outdated
@@ -0,0 +1 @@
Skip test case in test_cmd_line for VxWorks doesn't support preexec when do Popen
Copy link
Member

@vstinnervstinnerApr 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I'm not sure that it's worth it to document invidivual tests changes. Can you please remove the NEWS entry? I will simply add the GitHub label "skip news".

@bedevere-bot
Copy link

bedevere-bot commented Apr 17, 2019

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be poked with soft cushions!

@LihuaZhao
Copy link
ContributorAuthor

LihuaZhao commented Apr 17, 2019

I have made the requested changes; please review again.

@bedevere-bot
Copy link

bedevere-bot commented Apr 17, 2019

Thanks for making the requested changes!

@vstinner: please review the changes made to this pull request.

@vstinnervstinner merged commit 2954550 into python:masterApr 17, 2019
@bedevere-bot
Copy link

bedevere-bot commented Apr 17, 2019

@vstinner: Please replace # with GH- in the commit message next time. Thanks!

@LihuaZhaoLihuaZhao changed the title bpo-31904: skip test_cmd_line case for VxWorks doesn't support preexecbpo-36648 : skip test_cmd_line case for VxWorks doesn't support preexecApr 17, 2019
@LihuaZhaoLihuaZhao changed the title bpo-36648 : skip test_cmd_line case for VxWorks doesn't support preexecbpo-31094 : skip test_cmd_line case for VxWorks doesn't support preexecApr 17, 2019
@asvetlovasvetlov changed the title bpo-31094 : skip test_cmd_line case for VxWorks doesn't support preexecbpo-31904 : skip test_cmd_line case for VxWorks doesn't support preexecApr 17, 2019
@pxinwrpxinwr deleted the fix-skip-cmd-line branch July 12, 2021 09:42
@kuhlenoughkuhlenoughmannequin mentioned this pull request Jan 12, 2024
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes

Assignees

No one assigned

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LihuaZhao@bedevere-bot@vstinner@the-knights-who-say-ni