gh-89640: Pull in update to float word order detection in autoconf-archive#126747
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
erlend-aasland changed the title 
Contributor
erlend-aasland commented Nov 12, 2024
I guess the check-if-autoconf-files-are-up-to-date CI also needs an update; see |
…nf-archive Pulls in the updated docker container from this PR: python/cpython-devcontainers#34 which contains the autoconf-archive PR: autoconf-archive/autoconf-archive#316 I removed the workaround from configure.ac, regenerated everything, and manually tested that the fix works.
hoodmaneforce-pushed the update-float-word-detection branch from c4cee99 to ea9a348CompareContributorAuthor
hoodmane commented Nov 13, 2024
Okay, autoconf up to date check passes now. |
erlend-aasland approved these changes Nov 13, 2024
Contributor
erlend-aasland left a comment
erlend-aasland left a comment There was a problem hiding this comment.
Thanks!
For future reference: we normally try to avoid force-pushing, since it can make reviewing harder.
picnixz pushed a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulls in the updated docker container from this PR: python/cpython-devcontainers#34 which contains the autoconf-archive PR:
autoconf-archive/autoconf-archive#316
I removed the workaround from configure.ac, regenerated everything, and manually tested that the fix works.