GH-124567: Reduce overhead of debug build for GC. Should help CI performance#126777
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
MemberAuthor
markshannon commented Nov 13, 2024
Reduces the time it takes CI to run the |
Member
pablogsal commented Nov 13, 2024
Not opposing to this but this will mean that debug builds that are redistributed won't have GC list validation so linked list corruption will be more difficult to debug when users leverage debug builds of the interpreter. |
MemberAuthor
markshannon commented Nov 13, 2024
This only removes the extra asserts added for the incremental GC, the original list validations from 3.13 are still present. |
Member
pablogsal commented Nov 14, 2024
Sorry I was confused by the diff |
brandtbucher approved these changes Nov 14, 2024
Member
brandtbucher left a comment
brandtbucher left a comment There was a problem hiding this comment.
Looks good. I'm guessing validate_list is the cheapest (or most useful) check?
picnixz pushed a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The doctests CI takes ages and it uses a debug build.
Arguably debug builds should be good for debugging, i.e. lots of asserts. If you want performance don't use a debug build.
However, the incremental GC does adds a lot of extra sanity checks and it is a pain if CI jobs take half an hour or more.
So, this PR adds an extra debug option to reduce the amount of checking done in a normal debug build, but keeps the extra sanity checks if needed for debugging the GC.
📚 Documentation preview 📚: https://cpython-previews--126777.org.readthedocs.build/