Skip to content

Conversation

@picnixz
Copy link
Member

@picnixzpicnixz commented Nov 15, 2024

@bedevere-appbedevere-appbot added docs Documentation in the Doc dir skip news awaiting review labels Nov 15, 2024
@picnixzpicnixz removed docs Documentation in the Doc dir awaiting review labels Nov 15, 2024
@picnixzpicnixz requested a review from hugovkNovember 15, 2024 09:01
@hugovkhugovk merged commit e174869 into python:mainNov 15, 2024
@hugovk
Copy link
Member

Thanks!

@picnixzpicnixz deleted the docs/fixp-uuid-v8-89083 branch November 15, 2024 12:52
@picnixz
Copy link
MemberAuthor

Oh, I actually used a versionadded. It does not really matter here but semantically speaking, maybe a versionchanged would have been better? I used that directive in the v6 and v8 PRs but let's not change it in a follow-up commit (it's not really an issue).

@hugovk
Copy link
Member

In that we're adding uuid8() and changing the CLI to support version 8?

We could also say we're adding uuid8() and adding version 8 to the CLI. I don't mind too much either way :)

@picnixz
Copy link
MemberAuthor

In that we're adding uuid8() and changing the CLI to support version 8?

Yes. In addition, our convention seems to the "changed in version XXX" when we add new parameters or if there's already a versionadded for the object being documented (in this case the CLI program).

picnixz added a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants

@picnixz@hugovk