Skip to content

gh-126914: Use an atomic field for determining if the initial thread can be used#126915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ZeroIntensity wants to merge 8 commits into from
Closed

gh-126914: Use an atomic field for determining if the initial thread can be used #126915

ZeroIntensity wants to merge 8 commits into from

Conversation

@ZeroIntensity
Copy link
Member

@ZeroIntensityZeroIntensity commented Nov 16, 2024•
edited by bedevere-app bot
Loading

@bedevere-appbedevere-appbot mentioned this pull request Nov 16, 2024
Closed
@ZeroIntensityZeroIntensity changed the title gh-126914: Lock the runtime for longer during thread state deletiongh-126914: Lock the runtime for the entirety of thread state deletionNov 16, 2024
@ZeroIntensity
Copy link
MemberAuthor

ZeroIntensity commented Nov 17, 2024

QSBR seems to be breaking on free-threading for whatever reason :(

@ZeroIntensityZeroIntensity marked this pull request as draft November 17, 2024 02:14
@ZeroIntensityZeroIntensity changed the title gh-126914: Lock the runtime for the entirety of thread state deletiongh-126914: Use an atomic field for determining if the initial thread can be usedNov 17, 2024
@ZeroIntensity
Copy link
MemberAuthor

ZeroIntensity commented Nov 17, 2024

Looks like the new fix works. Yay!

@ZeroIntensityZeroIntensity marked this pull request as ready for review November 17, 2024 21:07
@ericsnowcurrently
Copy link
Member

ericsnowcurrently commented Nov 19, 2024

While this solution makes sense, I have some thoughts on an alternate approach that will be better for us long-term. See gh-126989.

@ZeroIntensityZeroIntensity mentioned this pull request Nov 19, 2024
Merged
@ZeroIntensity
Copy link
MemberAuthor

ZeroIntensity commented Nov 19, 2024

Closing in favor of GH-126989

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

Assignees

No one assigned

Labels

awaiting reviewneeds backport to 3.13bugs and security fixestopic-subinterpreters

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ZeroIntensity@ericsnowcurrently