Skip to content

gh-125723: Fix crash with f_locals when generator frame outlive their generator#126956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sobolevn merged 4 commits into from
Jan 22, 2025
Merged

gh-125723: Fix crash with f_locals when generator frame outlive their generator #126956

sobolevn merged 4 commits into from
Jan 22, 2025

Conversation

@efimov-mikhail
Copy link
Member

@efimov-mikhailefimov-mikhail commented Nov 18, 2024•
edited by bedevere-app bot
Loading

It seems that this PR had a problem.
It provides incorrect clearing of generator frame locals without checking any another references on this frame.
In this PR we can see a more accurate way of clearing such a frame.

@bedevere-appbedevere-appbot mentioned this pull request Nov 18, 2024
Closed
@efimov-mikhail
Copy link
MemberAuthor

efimov-mikhail commented Nov 18, 2024

cc @ncoghlan

Eclips4
Eclips4 reviewed Nov 18, 2024
View reviewed changes
markshannon
markshannon approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@markshannonmarkshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Nice clean fix and thorough tests.

@efimov-mikhail
Copy link
MemberAuthor

efimov-mikhail commented Dec 7, 2024

So, this PR can be merged? Or there's something I should improve?

@sobolevn
Copy link
Member

sobolevn commented Jan 19, 2025

I am planning to merge this in a couple of days if no one has objections.

ncoghlan
ncoghlan approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@ncoghlanncoghlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, too! Nice detective work, thanks. Minor typo fix suggestion in the NEWS entry.

@sobolevnsobolevn merged commit 8e20e42 into python:mainJan 22, 2025
41 checks passed
@ncoghlanncoghlan added the needs backport to 3.13 bugs and security fixes label Jun 12, 2025
@miss-islington-app
Copy link

miss-islington-appbot commented Jun 12, 2025

Thanks @efimov-mikhail for the PR, and @sobolevn for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington-app
Copy link

miss-islington-appbot commented Jun 12, 2025

Sorry, @efimov-mikhail and @sobolevn, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 8e20e42cc63321dacc500d7670bfc225ca04e78b 3.13

@ncoghlanncoghlan removed the needs backport to 3.13 bugs and security fixes label Jun 12, 2025
@bedevere-app
Copy link

bedevere-appbot commented Jun 13, 2025

GH-135453 is a backport of this pull request to the 3.13 branch.

ncoghlan pushed a commit that referenced this pull request Jun 13, 2025
@efimov-mikhail
[3.13]gh-125723: Fix crash with f_locals when generator frame outliv…
e753a7c
…e their generator (GH-135453) Backport of 8e20e42 from GH-126956ClosesGH-125723
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Eclips4Eclips4Eclips4 left review comments

@ncoghlanncoghlanncoghlan approved these changes

@sobolevnsobolevnsobolevn approved these changes

@markshannonmarkshannonmarkshannon approved these changes

@iritkatrieliritkatrielAwaiting requested review from iritkatriel

Assignees

@sobolevnsobolevn

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@efimov-mikhail@sobolevn@ncoghlan@markshannon@Eclips4