Revert "GH-126491: GC: Mark objects reachable from roots before doing cycle collection (GH-126502)"#126983
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
… doing cycle collection (pythonGH-126502)" This reverts commit b0fcc2c.
hugovk added the 🔨 test-with-buildbots 
bedevere-bot commented Nov 18, 2024
bedevere-bot removed the 🔨 test-with-buildbots hugovk requested review from ericsnowcurrently, markshannon and methane as code owners
MemberAuthor
hugovk commented Nov 19, 2024
Merged because it's 3.14.0a2 release day and there's two failing tier-1 buildbots, two failing tier-2, and six failing tier-3. Tier-1 need fixing/reverting immediately and tier-2 within 24 hours. The first failing tier-1 was 14 hours ago and tier-2 was 18 hours ago. |
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
… doing cycle collection (pythonGH-126502)" (python#126983)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit b0fcc2c.