Skip to content

Conversation

@savannahostrowski
Copy link
Member

@savannahostrowskisavannahostrowski commented Nov 24, 2024

@brandtbucher I'm assuming you still wanted to keep --with-lto wherever that's used but let me know if you'd also like to strip that out.

@savannahostrowskisavannahostrowski linked an issue Nov 24, 2024 that may be closed by this pull request
@alonme
Copy link
Contributor

Not totally related,
However it seems to me that these 2 lines are also unnecessary?

@savannahostrowskisavannahostrowski changed the title GH-127154: Remove PGO from JIT CIGH-127154: Remove PGO from debug JIT CINov 24, 2024
@savannahostrowski
Copy link
MemberAuthor

savannahostrowski commented Nov 24, 2024

@alonmeHmmm, I don't think so because those lines refer to non-debug builds.

I realized the title of this PR could be misleading, so I updated it to reflect that it is specifically for debug builds.

Haha, you're right. The double negative hurt my brain. Updating, thanks!

@savannahostrowskisavannahostrowski changed the title GH-127154: Remove PGO from debug JIT CIGH-127154: Remove PGO fromJIT CINov 24, 2024
@savannahostrowskisavannahostrowski changed the title GH-127154: Remove PGO fromJIT CIGH-127154: Remove PGO from JIT CINov 24, 2024
@brandtbucher
Copy link
Member

Nice, let's also drop LTO though (like PGO, it doesn't actually give us any useful new coverage and just takes forever).

How do you feel about also removing the four *-unknown-linux-gnu/clang builds while we're at it? Clang is supposed to be ABI-compatible with GCC, so it sort of just seems like we're wasting more time with those builds (and getting Clang to work properly on those builds requires setting the CC env var and another tweak or two that I forget).

Copy link
Member

@brandtbucherbrandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this is like a ~40% reduction in resources spent running JIT CI!

Two more suggestions for cleanup:

@savannahostrowskisavannahostrowski merged commit 2247dd0 into python:mainNov 27, 2024
47 checks passed
@savannahostrowskisavannahostrowski deleted the gh-127154 branch November 27, 2024 22:36
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Turn off PGO for JIT CI

3 participants

@savannahostrowski@alonme@brandtbucher