Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34k
gh-126890: Restore stripped ssl docstrings#127281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-126890: Restore stripped ssl docstrings #127281
Uh oh!
There was an error while loading. Please reload this page.
Conversation
ZeroIntensity commented Nov 26, 2024 • edited by bedevere-app bot
Loading Uh oh!
There was an error while loading. Please reload this page.
edited by bedevere-app bot
Uh oh!
There was an error while loading. Please reload this page.
encukou commented Nov 26, 2024
At a first glance at those warnings, it looks like this might need some changes in clinic :( |
neonene commented Nov 26, 2024
Please add a docstring for I think the warnings are related to the following regression: 3.12 on Windows: This PR: |
ZeroIntensity commented Nov 26, 2024
As far as I can tell, the warnings are a clinic bug. |
erlend-aasland commented Nov 26, 2024
Can we tear out the Argument Clinic bug fix as a separate PR? |
ZeroIntensity commented Nov 26, 2024
Yeah, I'll do that. A fair warning: it might take me a little while to get the PR up; I'm currently on a slow connection and GitHub takes forever. |
Uh oh!
There was an error while loading. Please reload this page.
neonene commented Dec 1, 2024 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
Thanks. I confirmed the following 16 PyDoc_STRVAR(PySSL_set_context_doc, ...) PyDoc_STRVAR(PySSL_get_server_side_doc, ...) PyDoc_STRVAR(PySSL_get_server_hostname_doc, ...) PyDoc_STRVAR(PySSL_get_owner_doc, ...) PyDoc_STRVAR(PySSL_set_session_doc, ...) PyDoc_STRVAR(PySSL_get_session_reused_doc, ...) PyDoc_STRVAR(PySSLContext_num_tickets_doc, ...) PyDoc_STRVAR(PySSLContext_security_level_doc, ...) PyDoc_STRVAR(PySSLContext_sni_callback_doc, ...) PyDoc_STRVAR(PySSL_memory_bio_pending_doc, ...) PyDoc_STRVAR(PySSL_memory_bio_eof_doc, ...) PyDoc_STRVAR(PySSLSession_get_time_doc, ...) PyDoc_STRVAR(PySSLSession_get_timeout_doc, ...) PyDoc_STRVAR(PySSLSession_get_ticket_lifetime_hint_doc, ...) PyDoc_STRVAR(PySSLSession_get_session_id_doc, ...) PyDoc_STRVAR(PySSLSession_get_has_ticket_doc, ...)Details>>>help(_ssl._SSLSocket.context) Helpongetsetdescriptor_ssl._SSLSocket.context: contextThischangesthecontextassociatedwiththeSSLSocket. Thisistypicallyusedfromwithinacallbackfunctionsetbythesni_callbackontheSSLContexttochangethecertificateinformationassociatedwiththeSSLSocketbeforethecryptographicexchangehandshakemessages. >>>help(_ssl._SSLSocket.server_side) Helpongetsetdescriptor_ssl._SSLSocket.server_side: server_sideWhetherthisisaserver-sidesocket. >>>help(_ssl._SSLSocket.server_hostname) Helpongetsetdescriptor_ssl._SSLSocket.server_hostname: server_hostnameThecurrentlysetserverhostname (forSNI). >>>help(_ssl._SSLSocket.owner) Helpongetsetdescriptor_ssl._SSLSocket.owner: ownerThePython-levelownerofthisobject. Passedas"self"inservernamecallback. >>>help(_ssl._SSLSocket.session) Helpongetsetdescriptor_ssl._SSLSocket.session: sessionTheunderlyingSSLSessionobject. >>>help(_ssl._SSLSocket.session_reused) Helpongetsetdescriptor_ssl._SSLSocket.session_reused: session_reusedWastheclientsessionreusedduringhandshake? >>>help(_ssl._SSLContext.num_tickets) Helpongetsetdescriptor_ssl._SSLContext.num_tickets: num_ticketsControlthenumberofTLSv1.3sessiontickets. >>>help(_ssl._SSLContext.security_level) Helpongetsetdescriptor_ssl._SSLContext.security_level: security_levelThecurrentsecuritylevel. >>>help(_ssl._SSLContext.sni_callback) Helpongetsetdescriptor_ssl._SSLContext.sni_callback: sni_callbackSetacallbackthatwillbecalledwhenaservernameisprovidedbytheSSL/TLSclientintheSNIextension. IftheargumentisNonethenthecallbackisdisabled. ThemethodiscalledwiththeSSLSocket, theservernameasastring, andtheSSLContextobject. SeeRFC6066fordetailsoftheSNIextension. >>>help(_ssl.MemoryBIO.pending) Helpongetsetdescriptor_ssl.MemoryBIO.pending: pendingThenumberofbytespendinginthememoryBIO. >>>help(_ssl.MemoryBIO.eof) Helpongetsetdescriptor_ssl.MemoryBIO.eof: eofWhetherthememoryBIOisatEOF. >>>help(_ssl.SSLSession.time) Helpongetsetdescriptor_ssl.SSLSession.time: timeSessioncreationtime (secondssinceepoch). >>>help(_ssl.SSLSession.timeout) Helpongetsetdescriptor_ssl.SSLSession.timeout: timeoutSessiontimeout (deltainseconds). >>>help(_ssl.SSLSession.ticket_lifetime_hint) Helpongetsetdescriptor_ssl.SSLSession.ticket_lifetime_hint: ticket_lifetime_hintTicketlifetimehint. >>>help(_ssl.SSLSession.id) Helpongetsetdescriptor_ssl.SSLSession.id: idSessionID. >>>help(_ssl.SSLSession.has_ticket) Helpongetsetdescriptor_ssl.SSLSession.has_ticket: has_ticketDoesthesessioncontainaticket? >>> |
c112de1 into python:mainUh oh!
There was an error while loading. Please reload this page.
encukou commented Dec 2, 2024
Thank you for following up! |
ZeroIntensity commented Dec 2, 2024
Thanks @ZeroIntensity for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Sorry, @ZeroIntensity and @encukou, I could not cleanly backport this to |
ZeroIntensity commented Dec 2, 2024
I figured that might happen :(. I'll look into it. |
…27281) (cherry picked from commit c112de1) Co-authored-by: Peter Bierma <[email protected]>
GH-127513 is a backport of this pull request to the 3.13 branch. |
) (cherry picked from commit c112de1) Co-authored-by: Peter Bierma <[email protected]>
In GH-124993, I forgot to carry over some of the docstrings to AC. This adds all of them back.
ssl#126890