gh-127518: Fix pystats build after #127169#127526
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
colesbury changed the title 
colesbury approved these changes Dec 2, 2024
Contributor
colesbury left a comment
colesbury left a comment There was a problem hiding this comment.
Ooops... thanks for fixing this!
Contributor
colesbury commented Dec 2, 2024
macOS free threading CI failure should be fixed by #127524 |
ContributorAuthor
mdboom commented Dec 2, 2024
No problem. We don't have CI for it... |
Contributor
colesbury commented Dec 2, 2024
#127524 has been merged so I merged "main" into this PR in order to fix the CI issue. |
mdboom merged commit edefb86 into python:main 35 checks passed
Uh oh!
There was an error while loading. Please reload this page.
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
pythongh-127518: Fix pystats build after python#127619
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
pythongh-127518: Fix pystats build after python#127619
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pystats build broke in #127169 due to the reorganization of
_Py_Specialize_StoreSubscr. This seems to do the right thing.--enable-pystatsbuild fails on main #127518