gh-119182: Complete PyUnicodeWriter documentation#127607
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
MemberAuthor
vstinner commented Dec 4, 2024
StanFromIreland approved these changes Dec 4, 2024
skirpichev approved these changes Dec 5, 2024
Member
skirpichev left a comment
skirpichev left a comment There was a problem hiding this comment.
Looks good.
But, perhaps, you could move sentence "The instance must be destroyed by ... or ..." to the PyUnicodeWriter_Create() docs.
kumaraditya303 approved these changes Dec 5, 2024
vstinner merged commit 1ef6e8c into python:main 32 checks passed
Uh oh!
There was an error while loading. Please reload this page.
MemberAuthor
vstinner commented Dec 5, 2024
Merged, thanks for reviews. |
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--127607.org.readthedocs.build/