Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34k
gh-126004: fix positions handling in codecs.replace_errors#127674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-126004: fix positions handling in codecs.replace_errors#127674
Uh oh!
There was an error while loading. Please reload this page.
Conversation
picnixz commented Dec 6, 2024 • edited by bedevere-app bot
Loading Uh oh!
There was an error while loading. Please reload this page.
edited by bedevere-app bot
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
vstinner left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
225296c into python:mainUh oh!
There was an error while loading. Please reload this page.
bedevere-bot commented Jan 23, 2025
|
bedevere-bot commented Jan 23, 2025
|
picnixz commented Jan 23, 2025
The iOS failures seem unrelated though I cannot confirm and the Android failure may be related so I'll check |
picnixz commented Jan 23, 2025
The code that seems to fail is: self.assertEqual(write_len, stream.write(b)) iflinesisNone: lines= [b.decode()] self.assert_logs(level, tag, lines)However, we're using a defsetUp(self): self.logcat_process=subprocess.Popen( ["logcat", "-v", "tag"], stdout=subprocess.PIPE, errors="backslashreplace" )so I don't know how it was affected by this change. I'll rerun the build bot for this one and if it still fails, I'll revert the PR. |
picnixz commented Jan 23, 2025
!buildbot aarch64 Android 3.x |
bedevere-bot commented Jan 23, 2025
The regex 'aarch64 Android 3.x' did not match any buildbot builder. Is the requested builder in the list of stable builders? |
picnixz commented Jan 23, 2025 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
Nevermind, the two build bots are actually green on the latest main ¯\_(ツ)_/¯ |
mhsmith commented Jan 23, 2025
I'm not sure what happened with the iOS buildbot, but the Android failure is a known problem: #124666. |
picnixz commented Jan 23, 2025 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
Thank you for confirming this. iOS build bot seems to never run so it could be a network issue or build bot issue. |
mhsmith commented Jan 23, 2025
The iOS buildbot had some issues recently (#129200), but it should be back to normal now. This particular failure is one I haven't seen before – it looks like it passed the test suite and then crashed at the end. |
startandendvalues incodecserror handlers #126004