Skip to content

gh-126004: fix positions handling in codecs.backslashreplace_errors#127676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
picnixz merged 15 commits into from
Jan 23, 2025
Merged

gh-126004: fix positions handling in codecs.backslashreplace_errors#127676

picnixz merged 15 commits into from
Jan 23, 2025

Conversation

@picnixz
Copy link
Member

@picnixzpicnixz commented Dec 6, 2024•
edited by bedevere-app bot
Loading

@bedevere-appbedevere-appbot mentioned this pull request Dec 6, 2024
Closed
@picnixzpicnixz requested a review from encukouDecember 6, 2024 16:13
picnixz
picnixz commented Jan 3, 2025
View reviewed changes
@picnixzpicnixz requested a review from vstinnerJanuary 23, 2025 10:44
vstinner
vstinner reviewed Jan 23, 2025
View reviewed changes
vstinner
vstinner reviewed Jan 23, 2025
View reviewed changes
@picnixzpicnixz requested a review from vstinnerJanuary 23, 2025 12:29
vstinner
vstinner approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@picnixzpicnixz merged commit 25a614a into python:mainJan 23, 2025
45 checks passed
@picnixzpicnixz deleted the fix/codecs/backslashreplace-errors-126004 branch January 23, 2025 13:28
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes

@encukouencukouAwaiting requested review from encukou

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@picnixz@vstinner