Skip to content

gh-126004: remove redundant safeguards for codecs handlers tests#127680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
picnixz merged 5 commits into from
Jan 23, 2025
Merged

gh-126004: remove redundant safeguards for codecs handlers tests #127680

picnixz merged 5 commits into from
Jan 23, 2025

Conversation

@picnixz
Copy link
Member

@picnixzpicnixz commented Dec 6, 2024•
edited by bedevere-app bot
Loading

@bedevere-appbedevere-appbot mentioned this pull request Dec 6, 2024
Closed
@bedevere-appbedevere-appbot added tests Tests in the Lib/test dir awaiting review labels Dec 6, 2024
encukou
encukou reviewed Dec 6, 2024
View reviewed changes
@picnixzpicnixz requested a review from encukouDecember 28, 2024 10:17
@encukou
Copy link
Member

encukou commented Jan 6, 2025

I'd prefer merging this after the 3 fixes; at that point this would add additional assertions and remove the safe argument.

@picnixzpicnixz changed the title gh-126004: allow to mark codecs handlers tests as safegh-126004: remove safeguards for crashing codecs handlersJan 23, 2025
@picnixzpicnixz changed the title gh-126004: remove safeguards for crashing codecs handlersgh-126004: remove redundant safeguards for codecs handlersJan 23, 2025
@picnixzpicnixz changed the title gh-126004: remove redundant safeguards for codecs handlersgh-126004: remove redundant safeguards for codecs handlers testsJan 23, 2025
@picnixzpicnixz requested a review from vstinnerJanuary 23, 2025 13:57
vstinner
vstinner approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@picnixzpicnixz merged commit cf0b2da into python:mainJan 23, 2025
41 checks passed
@picnixzpicnixz deleted the fix/codecs/safe-handlers-126004 branch January 23, 2025 15:06
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes

@encukouencukouAwaiting requested review from encukou

Assignees

No one assigned

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@picnixz@encukou@vstinner