gh-127718: Add colour to test.regrtest output#127719
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
error: Name state is not defined [name-defined]
error: Cannot find implementation or library stub for module named _colorize [import-not-found]
sobolevn reviewed Dec 9, 2024
Member
sobolevn left a comment
sobolevn left a comment There was a problem hiding this comment.
Do we need to test this? We have https://github.com/python/cpython/blob/main/Lib/test/test_regrtest.py file where this might fit.
MemberAuthor
hugovk commented Dec 9, 2024
I've added some tests. |
Eclips4 approved these changes Dec 9, 2024
Member
Eclips4 left a comment
Eclips4 left a comment There was a problem hiding this comment.
LGTM.
Thank you Hugo for coloring unittest and our test suite!
hugovk merged commit 212448b into python:main 46 checks passed
Uh oh!
There was an error while loading. Please reload this page.
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Examples:
test.regrtestoutput #127718📚 Documentation preview 📚: https://cpython-previews--127719.org.readthedocs.build/en/127719/library/test.html#module-test.regrtest