Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34k
gh-127947: Repeat PyREPL key events on Windows when wRepeatCount > 1#127948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
SimonvBez commented Dec 14, 2024 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
Keys that are repeated into PyREPL were typed only once. This change makes those characters be typed the correct number of times.
ghost commented Dec 14, 2024 • edited by ghost
Loading Uh oh!
There was an error while loading. Please reload this page.
edited by ghost
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
ZeroIntensity left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's good to see new contributors :)
Could you add a test? See the devguide for how to write tests.
Misc/NEWS.d/next/Library/2024-12-14-16-28-33.gh-issue-127947.2W5rYh.rst Outdated Show resolvedHide resolved
Uh oh!
There was an error while loading. Please reload this page.
By simulating INPUT_RECORD being received
SimonvBez commented Jan 12, 2025
There was no test coverage for the |
ZeroIntensity commented Jan 12, 2025
I'll review this soon-ish. Could you deal with the merge conflicts in the meantime? |
SimonvBez commented Jan 12, 2025
I see #128389 has caused a merge conflict. The changes there are minimal, but it isn't marked as getting backported to 3.13. |
ZeroIntensity commented Jan 12, 2025
Nah, backporting is pretty easy even if the automation fails. Just deal with the conflicts on main and you're good. |
SimonvBez commented Jan 12, 2025 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
The one thing I'm not sure about is the current distinction between EDIT: I have been playing with it for a while, and there seems to be no change in behavior when allowing the |
And replaced deque.insert(0, o) with deque.appendleft(o) for O(1) insertion
SimonvBez commented Jan 13, 2025
I have no clue as to why one of the automated Ubuntu tests is failing of all things, considering there have only been pyrepl Windows-only changes. |
ZeroIntensity commented Jan 14, 2025
Hypothesis is known to be flaky right now. I've restarted the job for you, let me know if it continues to fail and I'll just rerun it until it works. |
Keys that are repeated into PyREPL were typed only once on Windows.
This has been consistently happening when typing a dead key repeatedly, such as when double-pressing the quote character on the US International keyboard layout.
This change makes those characters be typed the correct number of times.
wRepeatCounton Windows, causing incorrect 'dead key' behavior #127947