gh-127954: Document PyObject_DelItemString#127986
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
rruuaanng changed the title PyObject_DelItemString function documentationPyObject_DelItemString function documentation
ZeroIntensity added needs backport to 3.12 
Uh oh!
There was an error while loading. Please reload this page.
Eclips4 approved these changes Dec 16, 2024
picnixz approved these changes Dec 17, 2024
| .. c:function::intPyObject_DelItemString(PyObject *o, const char *key) | ||
| This is the same as :c:func:`PyObject_DelItem`, but *key* is |
Contributor
There was a problem hiding this comment.
This is the canonical1 way to write it (git grep -i "similar to" Doc/c-api for inspiration):
Suggested change
| This is the same as:c:func:`PyObject_DelItem`, but *key* is | |
| Similar to:c:func:`PyObject_DelItem`, but *key* is |
Footnotes
"This is the same as" is sometimes used, but "Similar to [...], but" is a more common, and also more concise. ↩
erlend-aasland changed the title PyObject_DelItemString function documentationPyObject_DelItemString
erlend-aasland approved these changes Jan 4, 2025
erlend-aasland merged commit 8ade153 into python:main 44 checks passed
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as outdated.
This comment was marked as outdated.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 4, 2025
(cherry picked from commit 8ade153) Co-authored-by: RUANG (James Roy) <rruuaanng@outlook.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 4, 2025
(cherry picked from commit 8ade153) Co-authored-by: RUANG (James Roy) <rruuaanng@outlook.com>
GH-128496 is a backport of this pull request to the 3.13 branch. |
GH-128497 is a backport of this pull request to the 3.12 branch. |
erlend-aasland pushed a commit that referenced this pull request Jan 4, 2025
erlend-aasland pushed a commit that referenced this pull request Jan 4, 2025
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 6, 2025
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyObject_DelItemStringis not documented #127954📚 Documentation preview 📚: https://cpython-previews--127986.org.readthedocs.build/