Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34k
gh-84559: improve What's New entry for multiprocessing start method changes#128173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-84559: improve What's New entry for multiprocessing start method changes #128173
Uh oh!
There was an error while loading. Please reload this page.
Conversation
picnixz commented Dec 22, 2024 • edited by github-actions bot
Loading Uh oh!
There was an error while loading. Please reload this page.
edited by github-actions bot
Uh oh!
There was an error while loading. Please reload this page.
hugovk commented Dec 22, 2024
Yeah, this sounds like a big change we want people to know about, let's add a summary up there and link down to multiprocessing part. I expect we'll expand the summary closer to the release, compare 3.13: https://docs.python.org/3/whatsnew/3.13.html#summary-release-highlights cc @AA-Turner |
Uh oh!
There was an error while loading. Please reload this page.
jakirkham commented Dec 22, 2024
Just a note, on macOS the default is spawn (as it has been for a while). However the docs also note that POSIX uses forkserver by default. Though macOS also is a POSIX platform. Should this be disambiguated somehow? |
picnixz commented Dec 22, 2024
Ah yes, sorry. it should have been "On POSIX platforms, except macOS, [...]" or "On platforms other than macOS and Windows". Which one would be the clearer? |
gpshead left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm glad we have a full section in the multiprocessing docs to link to (hooray past us!). But to help people from a What's New standpoint given the issues people are raising about this being confusing, I think we should pick a couple different short example error messages users might see coming out of an application that needs modification to work with the new start method when using multiprocessing or concurrent.futures.
picnixz commented Dec 24, 2024
What about improving the section in |
Uh oh!
There was an error while loading. Please reload this page.
gpshead commented Dec 25, 2024
Even just a sentence in What's New saying something along the lines of "if you are seeing name errors of pickling errors coming out of multiprocessing or concurrent.futures when you upgrade to 3.14, read ...link-to-section..." would help people understand. Expanding further upon that kind of thing in the multiprocessing docs as common issues would be good. |
Co-authored-by: Stan Ulbrych <[email protected]>
picnixz commented Dec 25, 2024
I'll have a look at what to link tomorrow and if I have the motivation, I'll do something for the mp docs. |
ngoldbaum commented Feb 19, 2025
Small ping that I ended up here after a discussion about this behavior and getting this docs improvement merged would help a lot. No rush of course but just don’t want this forgotten. |
picnixz commented Feb 21, 2025
Oh I forgot... I will try to make it by the end of the weekend. Let's make it as the next task. Thanks for the ping ! |
Uh oh!
There was an error while loading. Please reload this page.
b8c313a into python:mainUh oh!
There was an error while loading. Please reload this page.
… start method changes (pythonGH-128173) (cherry picked from commit b8c313a) Co-authored-by: Bénédikt Tran <[email protected]> Co-authored-by: Gregory P. Smith <[email protected]> Co-authored-by: Stan Ulbrych <[email protected]>
GH-137156 is a backport of this pull request to the 3.13 branch. |
…method changes (GH-128173) (#137156) [3.13] gh-84559: improve What's New entry for `multiprocessing` start method changes (GH-128173) (cherry picked from commit b8c313a) Co-authored-by: Bénédikt Tran <[email protected]> Co-authored-by: Gregory P. Smith <[email protected]> Co-authored-by: Stan Ulbrych <[email protected]>
This is a proposal for an improved changelog. I am tempted to add it at the very top of the file in the "Summary -- release highlights" but I don't know if @hugovk is ok or not with it.
'fork'is broken: change to `'forkserver' || 'spawn'#84559📚 Documentation preview 📚: https://cpython-previews--128173.org.readthedocs.build/