Skip to content

Conversation

@kumaraditya303
Copy link
Contributor

@kumaraditya303kumaraditya303 commented Dec 26, 2024

@bedevere-appbedevere-appbot mentioned this pull request Dec 26, 2024
7 tasks
@bedevere-appbedevere-appbot added the docs Documentation in the Doc dir label Dec 26, 2024
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Copy link
Member

@picnixzpicnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If you want to add .. deprecated to every class and functions you mentioned, you can do it but since you deprecated the entire module in one go, I don't know if it's worth it or not. The only reason why I would suggest this is for users that do an online search and for IDEs that render Python docs based on the remote docs and that would miss the top-level warning.

@kumaraditya303
Copy link
ContributorAuthor

If you want to add .. deprecated to every class and functions you mentioned, you can do it but since you deprecated the entire module in one go, I don't know if it's worth it or not.

That was already done as part of individual PRs.

image

@picnixz
Copy link
Member

Perfect! (sorry since the diff didn't show it I wasn't aware of; I thought you waited for those changes actually or I didn't remember this). My approval remains then.

@kumaraditya303kumaraditya303 merged commit 3eb746a into python:mainDec 26, 2024
29 checks passed
@kumaraditya303kumaraditya303 deleted the docs branch December 26, 2024 14:32
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docsDocumentation in the Doc dirskip newstopic-asyncio

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants

@kumaraditya303@picnixz@asvetlov@jnts1984@Eclips4