Skip to content

gh-128321: Set LIBS instead of LDFLAGS during sqlite3 library build checks#128322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
erlend-aasland merged 3 commits into from
Dec 30, 2024
Merged

gh-128321: Set LIBS instead of LDFLAGS during sqlite3 library build checks #128322

erlend-aasland merged 3 commits into from
Dec 30, 2024

Conversation

@zanieb
Copy link
Contributor

@zaniebzanieb commented Dec 29, 2024•
edited
Loading

Closes#128321

See the issue for context.

There are a few alternative approaches we could take, such as:

  • Always including -lm during checks (which would over-link)
  • Using PKG_CHECK_MODULES_STATIC instead of PKG_CHECK_MODULES when shared libraries are disabled

I'm not really sure of the trade-offs. This seems like the simplest approach to unblock users who can set PKG_CONFIG to include the --static flag as mentioned in https://bugs.freedesktop.org/show_bug.cgi?id=19541#c7

@bedevere-appbedevere-appbot mentioned this pull request Dec 29, 2024
Closed
erlend-aasland
erlend-aasland reviewed Dec 29, 2024
View reviewed changes
erlend-aasland
erlend-aasland reviewed Dec 30, 2024
View reviewed changes
@zaniebzanieb changed the title gh-128321: Set LIBS during sqlite3 library build checksgh-128321: Set LIBS instead of LDFLAGS during sqlite3 library build checksDec 30, 2024
@zaniebzanieb marked this pull request as ready for review December 30, 2024 05:24
@erlend-aaslanderlend-aasland merged commit 81376fe into python:mainDec 30, 2024
47 checks passed
@zanieb
Copy link
ContributorAuthor

zanieb commented Dec 30, 2024

Thanks for the review!

This was referenced Dec 30, 2024
Merged
Closed
@erlend-aaslanderlend-aasland added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Dec 30, 2024
@miss-islington-app

This comment was marked as outdated.

Sign in to view
@miss-islington-app

This comment was marked as outdated.

Sign in to view
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 30, 2024
@zanieb@erlend-aasland@miss-islington
pythongh-128321: Set LIBS instead of LDFLAGS when checking sqlite3 re…
e41e503
…quirements (pythonGH-128322) (cherry picked from commit 81376fe) Co-authored-by: Zanie Blue <contact@zanie.dev> Co-authored-by: Erlend E. Aasland <erlend@python.org>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 30, 2024
@zanieb@erlend-aasland@miss-islington
pythongh-128321: Set LIBS instead of LDFLAGS when checking sqlite3 re…
cd6a879
…quirements (pythonGH-128322) (cherry picked from commit 81376fe) Co-authored-by: Zanie Blue <contact@zanie.dev> Co-authored-by: Erlend E. Aasland <erlend@python.org>
@bedevere-app
Copy link

bedevere-appbot commented Dec 30, 2024

GH-128355 is a backport of this pull request to the 3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12 only security fixes label Dec 30, 2024
@bedevere-app
Copy link

bedevere-appbot commented Dec 30, 2024

GH-128356 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13 bugs and security fixes label Dec 30, 2024
erlend-aasland added a commit that referenced this pull request Dec 30, 2024
@miss-islington@zanieb@erlend-aasland
[3.12]gh-128321: Set LIBS instead of LDFLAGS when checking sqlite3 r…
4ddee55
…equirements (GH-128322) (#128355) (cherry picked from commit 81376fe) Co-authored-by: Zanie Blue <contact@zanie.dev> Co-authored-by: Erlend E. Aasland <erlend@python.org>
erlend-aasland added a commit that referenced this pull request Dec 30, 2024
@miss-islington@zanieb@erlend-aasland
[3.13]gh-128321: Set LIBS instead of LDFLAGS when checking sqlite3 r…
5a892cb
…equirements (GH-128322) (#128356) (cherry picked from commit 81376fe) Co-authored-by: Zanie Blue <contact@zanie.dev> Co-authored-by: Erlend E. Aasland <erlend@python.org>
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@zanieb@erlend-aasland@srinivasreddy
pythongh-128321: Set LIBS instead of LDFLAGS when checking sqlite3 re…
bcfcbb7
…quirements (python#128322) Co-authored-by: Erlend E. Aasland <erlend@python.org>
@solvingjsolvingj mentioned this pull request Feb 4, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes

@corona10corona10Awaiting requested review from corona10corona10 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Statically linked sqlite3 fails checks due to missing -lm

2 participants

@zanieb@erlend-aasland