Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34k
gh-128427: Add uuid.NIL and uuid.MAX#128429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
ngnpope commented Jan 2, 2025 • edited by github-actions bot
Loading Uh oh!
There was an error while loading. Please reload this page.
edited by github-actions bot
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Misc/NEWS.d/next/Library/2025-01-02-20-34-04.gh-issue-128427.onPoQZ.rst Outdated Show resolvedHide resolved
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
picnixz commented Jan 3, 2025 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
By the way, avoid force-pushing in the future as it makes reviews harder; we eventually squash commits and write our own commit message (force-pushing is accepted in some cases only but those are quite rare (like fixing up a really wrong commit that should not be seen at all, or changing the committer's email/name to due CLA reasons)). |
Uh oh!
There was an error while loading. Please reload this page.
picnixz left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot about the version and variant fields which I don't know what to do with.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
picnixz left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two nits and LGTM once a core dev allows it.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
hugovk left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, just a couple of docs suggestions.
| .. data:: NIL | ||
| A special form of UUID that is specified to have all 128 bits set to zero | ||
| according to :rfc:`RFC 9562, §5.9 <9562#section-5.9>`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linking directly to the section is helpful, perhaps we only need to mention the RFC number here? If so, we could update the same thing for uuid8 above.
| according to :rfc:`RFC 9562, §5.9 <9562#section-5.9>`. | |
| according to :rfc:`RFC 9562 <9562#section-5.9>`. |
| .. data:: MAX | ||
| A special form of UUID that is specified to have all 128 bits set to one | ||
| according to :rfc:`RFC 9562, §5.10 <9562#section-5.10>`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| according to :rfc:`RFC 9562, §5.10 <9562#section-5.10>`. | |
| according to :rfc:`RFC 9562 <9562#section-5.10>`. |
encukou left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it works better with the section number in the text.
hugovk commented Jan 27, 2025
Sure, let's merge. @ngnpope, thank you your contribution! |
8ec76d9 into python:mainUh oh!
There was an error while loading. Please reload this page.
Adds constants for Nil and Max UUID formats as per RFC 9562.
📚 Documentation preview 📚: https://cpython-previews--128429.org.readthedocs.build/