Skip to content

gh-127614: Correctly check for ttyname_r() in configure#128503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
erlend-aasland merged 1 commit into from
Jan 7, 2025
Merged

gh-127614: Correctly check for ttyname_r() in configure #128503

erlend-aasland merged 1 commit into from
Jan 7, 2025

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aaslanderlend-aasland commented Jan 4, 2025•
edited by bedevere-app bot
Loading

PR #14868 replaced the ttyname() call with ttyname_r(), but the old
check remained.

@erlend-aasland
pythongh-127614: Correctly check for ttyname_r() in configure
f25911a
PR python#14868 replaced the ttyname() call with ttyname_r(), but the old check remained.
@bedevere-appbedevere-appbot mentioned this pull request Jan 4, 2025
Closed
@erlend-aaslanderlend-aasland linked an issue Jan 4, 2025 that may be closed by this pull request
configure is checking for ttyname but code is using ttyname_r#127614
Closed
@erlend-aaslanderlend-aasland merged commit e08b282 into python:mainJan 7, 2025
47 checks passed
@erlend-aaslanderlend-aasland deleted the autoconf/detect-ttyname_r branch January 7, 2025 21:42
@miss-islington-app

This comment was marked as outdated.

Sign in to view
@miss-islington-app

This comment was marked as outdated.

Sign in to view
@miss-islington-app

This comment was marked as outdated.

Sign in to view
@bedevere-app
Copy link

bedevere-appbot commented Jan 7, 2025

GH-128598 is a backport of this pull request to the 3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13 bugs and security fixes label Jan 7, 2025
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Jan 7, 2025
@erlend-aasland
[3.13]pythongh-127614: Correctly check for ttyname_r() in configure (p…
cf1909a
…ython#128503) (cherry picked from commit e08b282) PR python#14868 replaced the ttyname() call with ttyname_r(), but the old check remained.
@bedevere-app
Copy link

bedevere-appbot commented Jan 7, 2025

GH-128599 is a backport of this pull request to the 3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12 only security fixes label Jan 7, 2025
erlend-aasland added a commit that referenced this pull request Jan 7, 2025
@erlend-aasland
[3.12]gh-127614: Correctly check for ttyname_r() in configure (#128503…
6b33719
…) (#128599) (cherry picked from commit e08b282) PR #14868 replaced the ttyname() call with ttyname_r(), but the old check remained.
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@erlend-aasland@srinivasreddy
pythongh-127614: Correctly check for ttyname_r() in configure (python…
ebc1cc2
…#128503) PR python#14868 replaced the ttyname() call with ttyname_r(), but the old check remained.
erlend-aasland added a commit that referenced this pull request Jan 11, 2025
@erlend-aasland
[3.13]gh-127614: Correctly check for ttyname_r() in configure (#128503…
436064a
…) (#128598) (cherry picked from commit e08b282) PR #14868 replaced the ttyname() call with ttyname_r(), but the old check remained.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10corona10Awaiting requested review from corona10corona10 is a code owner

Assignees

@erlend-aaslanderlend-aasland

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

configure is checking for ttyname but code is using ttyname_r

1 participant

@erlend-aasland