Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34k
gh-128691: Use deferred reference counting on _thread._local#128693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-128691: Use deferred reference counting on _thread._local#128693
Uh oh!
There was an error while loading. Please reload this page.
Conversation
colesbury commented Jan 9, 2025 • edited by bedevere-app bot
Loading Uh oh!
There was an error while loading. Please reload this page.
edited by bedevere-app bot
Uh oh!
There was an error while loading. Please reload this page.
This change, along with the LOAD_ATTR specializations, makes the "thread_local_read" micro benchmark in Tools/ftscalingbench/ftscalingbench.py scale well to multiple threads.
Uh oh!
There was an error while loading. Please reload this page.
c141748 into python:mainUh oh!
There was an error while loading. Please reload this page.
bedevere-bot commented Jan 10, 2025
|
encukou commented Jan 10, 2025
The buildbot failed again with the same error -- |
colesbury commented Jan 10, 2025
This change doesn't affect the default build. The added call is a no-op in that case. I'm pretty sure the buildbot is coincidentally in a bad state. Maybe too many zombie processes from previous runs or something like that. |
hugovk commented Jan 11, 2025
Perhaps a reboot of the buildbot machine might help? It's https://buildbot.python.org/#/builders/345 cc @Rosuav |
…_local` (python#128693)" This reverts commit c141748.
…_local` (python#128693)" This reverts commit c141748.
hugovk commented Jan 12, 2025 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
I made a draft revert PR (#128753) just to check the buildbots, and the "AMD64 Debian root" that failed here, passed there. Reminder that the next 3.14 release is due on Tuesday: https://peps.python.org/pep-0745/ |
colesbury commented Jan 12, 2025
And it also passed on main: https://buildbot.python.org/#/builders/345/builds/9920 |
hugovk commented Jan 12, 2025
... but the newest build on |
hugovk commented Jan 12, 2025
Yes, all looks good now :) |
This change, along with the LOAD_ATTR specializations, makes the "thread_local_read" micro benchmark in Tools/ftscalingbench/ftscalingbench.py scale well to multiple threads.
threading.local()access should scale well from multiple threads #128691