Skip to content

Conversation

@FFY00
Copy link
Member

@FFY00FFY00 commented Jan 11, 2025

@WolframAlph can you make sure this resolves your issue?

@bedevere-appbedevere-appbot added tests Tests in the Lib/test dir awaiting core review labels Jan 11, 2025
@FFY00FFY00 added skip news and removed tests Tests in the Lib/test dir awaiting core review labels Jan 11, 2025
@WolframAlph
Copy link
Contributor

Hi @FFY00 , unfortunately it is still failing :(

0:00:00 load avg: 4.90 Run 1 test sequentially in a single process 0:00:00 load avg: 4.90 [1/1] test_embed test test_embed failed -- Traceback (most recent call last): File "/Users/yyanchii/Desktop/cpython/Lib/test/test_embed.py", line 1676, in test_init_pyvenv_cfg self.check_all_configs("test_init_compat_config", config, ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ api=API_COMPAT, env=env, ^^^^^^^^^^^^^^^^^^^^^^^^ ignore_stderr=True, cwd=tmpdir) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/Users/yyanchii/Desktop/cpython/Lib/test/test_embed.py", line 943, in check_all_configs self.check_config(configs, expected_config) ~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/Users/yyanchii/Desktop/cpython/Lib/test/test_embed.py", line 869, in check_config self.assertEqual(config, expected) ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^ AssertionError:{'argv': [''], 'base_exec_prefix': '/usr/lo[2006 chars]None} !={'_config_init': 1, 'isolated': False, 'use[2106 chars]alse}{'_config_init': 1, '_init_main': True, '_install_importlib': True, 'argv': [''], - 'base_exec_prefix': '/usr/local', + 'base_exec_prefix': '/var/folders/z9/tt4sxxm159zbh6xlm2mhrg4r0000gp/T/tmpdf13u1a4', 'base_executable': '/var/folders/z9/tt4sxxm159zbh6xlm2mhrg4r0000gp/T/tmpdf13u1a4/_testembed', 'base_prefix': '/usr/local', 'buffered_stdio': True, 'bytes_warning': 0, 'check_hash_pycs_mode': 'default', 'code_debug_ranges': True, 'configure_c_stdio': False, 'cpu_count': -1, 'dev_mode': False, 'dump_refs': False, 'dump_refs_file': None, 'exec_prefix': '/private/var/folders/z9/tt4sxxm159zbh6xlm2mhrg4r0000gp/T/tmplkro5924', 'executable': '/private/var/folders/z9/tt4sxxm159zbh6xlm2mhrg4r0000gp/T/tmplkro5924/_testembed', 'faulthandler': False, 'hash_seed': 0, 'home': None, 'import_time': False, 'inspect': False, 'install_signal_handlers': True, 'int_max_str_digits': 4300, 'interactive': False, 'isolated': False, 'malloc_stats': False, 'module_search_paths': ['/usr/local/lib/python314.zip', '/Users/yyanchii/Desktop/cpython/Lib', '/Users/yyanchii/Desktop/cpython/build/lib.macosx-15.2-arm64-3.14', '/usr/local/lib/python314.zip', '/usr/local/lib/python3.14', - '/usr/local/lib/python3.14/lib-dynload'], + '/var/folders/z9/tt4sxxm159zbh6xlm2mhrg4r0000gp/T/tmpdf13u1a4/lib/python3.14/lib-dynload'], 'module_search_paths_set': True, 'optimization_level': 0, 'orig_argv': [], 'parse_argv': False, 'parser_debug': False, 'pathconfig_warnings': True, 'perf_profiling': 0, 'platlibdir': 'lib', 'prefix': '/private/var/folders/z9/tt4sxxm159zbh6xlm2mhrg4r0000gp/T/tmplkro5924', 'program_name': './_testembed', 'pycache_prefix': None, 'pythonpath_env': '/usr/local/lib/python314.zip:/Users/yyanchii/Desktop/cpython/Lib:/Users/yyanchii/Desktop/cpython/build/lib.macosx-15.2-arm64-3.14', 'quiet': False, 'run_command': None, 'run_filename': None, 'run_module': None, 'safe_path': False, 'show_ref_count': False, 'site_import': True, 'skip_source_first_line': False, 'sys_path_0': None, 'tracemalloc': 0, 'use_environment': True, 'use_frozen_modules': True, 'use_hash_seed': False, 'use_system_logger': False, 'user_site_directory': True, 'verbose': 0, 'warn_default_encoding': False, 'warnoptions': [], 'write_bytecode': True, 'xoptions':{}} test_embed failed (1 failure) == Tests result: FAILURE == 1 test failed: test_embed

is_emscripten = sys.platform == "emscripten"
is_wasi = sys.platform == "wasi"

has_runtime_library = bool(hasattr(sys, 'dllhandle') or sysconfig.get_config_var('LD_LIBRARY'))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
has_runtime_library=bool(hasattr(sys, 'dllhandle') orsysconfig.get_config_var('LD_LIBRARY'))
has_runtime_library=bool(hasattr(sys, 'dllhandle') orsysconfig.get_config_var('LDLIBRARY'))

At least that's the variable I see here — and I can confirm that with this change, 3.14.0a4's test suite passes now for me.

@vstinner
Copy link
Member

It's no longer needed to skip the test, I updated the test instead: #129137

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@FFY00@WolframAlph@vstinner@mgorny